----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64581/#review193748 -----------------------------------------------------------
src/examples/test_csi_plugin.cpp Lines 110 (patched) <https://reviews.apache.org/r/64581/#comment272385> Let's pass in `hashmap<string, Bytes> volumes` here and do the parsing in main function. src/examples/test_csi_plugin.cpp Lines 129-148 (patched) <https://reviews.apache.org/r/64581/#comment272386> Please move this to main function. - Jie Yu On Dec. 13, 2017, 11:32 p.m., Chun-Hung Hsiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64581/ > ----------------------------------------------------------- > > (Updated Dec. 13, 2017, 11:32 p.m.) > > > Review request for mesos, Greg Mann, Jie Yu, and Joseph Wu. > > > Repository: mesos > > > Description > ------- > > Example: `--volumes "volume1:1GB;volume2:2GB"`. > > This patch also changes `--total_capacity` to `--available_capacity` to > follow the latest CSI spec, and fixed a compilation bug with clang 3.9. > > > Diffs > ----- > > src/examples/test_csi_plugin.cpp 6359db8666e03d7e9d2365011d9a11fde6fdbba7 > src/tests/agent_resource_provider_config_api_tests.cpp > 5a50e825aeefbb26430de5d3c8f44afba64945b5 > src/tests/storage_local_resource_provider_tests.cpp > e5868bfcb71977d2b2a146865f12a5207010ae40 > > > Diff: https://reviews.apache.org/r/64581/diff/1/ > > > Testing > ------- > > sudo make check > > > Thanks, > > Chun-Hung Hsiao > >
