----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64588/#review193765 -----------------------------------------------------------
Fix it, then Ship it! src/slave/slave.cpp Line 7257 (original), 7272 (patched) <https://reviews.apache.org/r/64588/#comment272407> looks like only one difference between the two LOG(INFO) here? I'd combine them: ``` LOG(INFO) << "Forwarding status update of " << (operation == nullptr ? "unknown " : "") << "offer operation" << (update.status().has_operation_id() ? " '" + stringify(update.status().operation_id()) + "'" : "") << " (uuid: " << operationUUID->toString() << ")" << " for framework " << update.framework_id(); ``` - Jie Yu On Dec. 14, 2017, 1:55 a.m., Gaston Kleiman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64588/ > ----------------------------------------------------------- > > (Updated Dec. 14, 2017, 1:55 a.m.) > > > Review request for mesos, Chun-Hung Hsiao, Greg Mann, and Jie Yu. > > > Repository: mesos > > > Description > ------- > > There are some cases in which an agent can get offer operation status > updates for operations that it doesn't know about. > > If this happens, the agent should forward the updates to the master > without updating its internal state. > > > Diffs > ----- > > src/slave/slave.cpp e8f7591dc0d57ca8a0eb72f6c1c008d4005a524d > > > Diff: https://reviews.apache.org/r/64588/diff/1/ > > > Testing > ------- > > `make check` on GNU/Linux > > > Thanks, > > Gaston Kleiman > >
