----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63971/#review193771 -----------------------------------------------------------
Fix it, then Ship it! include/mesos/resource_provider/volume_profile.hpp Lines 49 (patched) <https://reviews.apache.org/r/63971/#comment272414> I thought the more common spelling is Adapter. Do we prefer Adaptor in the codebase? - Chun-Hung Hsiao On Dec. 6, 2017, 11:50 p.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63971/ > ----------------------------------------------------------- > > (Updated Dec. 6, 2017, 11:50 p.m.) > > > Review request for mesos, Chun-Hung Hsiao and Jie Yu. > > > Bugs: MESOS-8251 > https://issues.apache.org/jira/browse/MESOS-8251 > > > Repository: mesos > > > Description > ------- > > This module is currently intended for use by the Storage Local > Resource Provider (SLRP), but may be used by other components if > those components use any of the affected Container Storage Interface > (CSI) requests. The affected calls are listed in the module's comments. > > > Diffs > ----- > > include/mesos/mesos.proto 5b93478ed1a8250b05c44ec8b4d1f660a2053b87 > include/mesos/resource_provider/volume_profile.hpp PRE-CREATION > include/mesos/v1/mesos.proto 22b3c6889d975147b001ef145ba4fc382debf70a > > > Diff: https://reviews.apache.org/r/63971/diff/6/ > > > Testing > ------- > > See end of chain. > > > Thanks, > > Joseph Wu > >