----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64506/#review193846 -----------------------------------------------------------
Ship it! Could you please file a ticket that describes the bug from what a user would experience, and link that in to the review? I would like to target it for backporting, seems pretty bad. src/master/master.cpp Lines 6433-6434 (patched) <https://reviews.apache.org/r/64506/#comment272477> Yeah, this is long overdue, maybe I should resurrect my patch for this. :) - Benjamin Mahler On Dec. 14, 2017, 3:32 p.m., Benno Evers wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64506/ > ----------------------------------------------------------- > > (Updated Dec. 14, 2017, 3:32 p.m.) > > > Review request for mesos and Benjamin Mahler. > > > Repository: mesos > > > Description > ------- > > Previously, the slave was not erased from the `registering` > and `reregistering` sets in the master for some code paths > that would result in a failed (re-)registration attempt. > > This could lead to a state where the reason of the unsuccessful > (re-)registration attempt is fixed on the agent, but the master > ignores subsequent attempts because it assumes the previous > operation is still in progress. > > > Diffs > ----- > > src/master/master.cpp b3e074cfe86600793310deb87932fa145e95055d > src/tests/master_tests.cpp 7b087675200fe0ca69319b715997700a91d9f6b2 > > > Diff: https://reviews.apache.org/r/64506/diff/2/ > > > Testing > ------- > > `make check` > > > Thanks, > > Benno Evers > >
