----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64591/#review193964 -----------------------------------------------------------
Fix it, then Ship it! src/v1/resources.cpp Lines 2124 (patched) <https://reviews.apache.org/r/64591/#comment272653> I'd prefer `id` to be at the front - Jie Yu On Dec. 14, 2017, 1:55 a.m., Chun-Hung Hsiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64591/ > ----------------------------------------------------------- > > (Updated Dec. 14, 2017, 1:55 a.m.) > > > Review request for mesos and Jie Yu. > > > Repository: mesos > > > Description > ------- > > `Resource::DiskInfo::Source` is printed out in the following formats: > > TYPE(profile,id):root > > If the source has no profile and ID, then "(profile,id)" will be > skipped. If either the profile or the ID is missing, the missing part > will be replaced with an empty string. If the source has no root path, > ":root" will be skipped. > > > Diffs > ----- > > src/common/resources.cpp 2774372bb52d9d60847a8230282068432b28b054 > src/v1/resources.cpp 43d9b0f48c345b4574171cffbd1dc07bda1d1546 > > > Diff: https://reviews.apache.org/r/64591/diff/1/ > > > Testing > ------- > > sudo make check > > > Thanks, > > Chun-Hung Hsiao > >
