----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64680/ -----------------------------------------------------------
Review request for mesos, Alexander Rukletsov and Gilbert Song. Bugs: MESOS-8267 https://issues.apache.org/jira/browse/MESOS-8267 Repository: mesos Description ------- Containerizer recovery returns control to the caller before completion of destruction of orphaned containers. Previously, `wait` was called on a container right after calling `recover`, so `wait` was almost always successfull, because destruction of the orphaned container takes some time to complete. This patch replaces check for the container existence with the check that a related freezer cgroup has been destroyed. The freezer cgroup is destroyed during container destruction initiated by a containerizer recovery process. Diffs ----- src/tests/containerizer/nested_mesos_containerizer_tests.cpp 22bd9955140ef1c75d8bb78faa6e6d50a71c2318 Diff: https://reviews.apache.org/r/64680/diff/1/ Testing ------- 1. make check 2. `./src/mesos-tests --gtest_filter=NestedMesosContainerizerTest.ROOT_CGROUPS_RecoverLauncherOrphans --gtest_break_on_failure --gtest_repeat=1000` Thanks, Andrei Budnik