----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64033/#review194092 -----------------------------------------------------------
src/docker/executor.cpp Lines 389 (patched) <https://reviews.apache.org/r/64033/#comment272810> Let's do a `CHECK_SOME(run)` because this is not expected to happen as far as we can tell. Can you link the JIRA for posterity? src/launcher/executor.cpp Lines 781 (patched) <https://reviews.apache.org/r/64033/#comment272811> ditto. do a CHECK here. - Vinod Kone On Dec. 4, 2017, 6:04 p.m., Alexander Rukletsov wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64033/ > ----------------------------------------------------------- > > (Updated Dec. 4, 2017, 6:04 p.m.) > > > Review request for mesos, Andrei Budnik, Anand Mazumdar, Armand Grillet, and > Vinod Kone. > > > Bugs: MESOS-8297 > https://issues.apache.org/jira/browse/MESOS-8297 > > > Repository: mesos > > > Description > ------- > > `ExecutorRegisteredMessage` or `RunTaskMessage` may not be delivered > to a driver-based executor. Since these messages are not retried, > without this patch an executor never starts a task and remains idle, > ignoring kill task request. This patch ensures all built-in driver- > based executors eventually shut down if kill task arrives before > the task has been started. > > > Diffs > ----- > > src/docker/executor.cpp 3974f20052e3c12eb154a5146d19d4dc1759859f > src/exec/exec.cpp cdbf149a9047ddad6beef64be1266e15e7643afc > src/launcher/executor.cpp c688c04e598ac140421fd5e47359b0e48d30bcc5 > > > Diff: https://reviews.apache.org/r/64033/diff/4/ > > > Testing > ------- > > make check on MacOS 10.11.6 > > Manual testing using modified "exec.cpp" that drops executor registration > confirmation. > > > Thanks, > > Alexander Rukletsov > >