----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64353/#review194098 -----------------------------------------------------------
Fix it, then Ship it! src/csi/uri_volume_profile.proto Lines 21 (patched) <https://reviews.apache.org/r/64353/#comment272822> I'd suggest we remove `uri_volume_profile` from the package name given the message name is pretty clear. - Jie Yu On Dec. 18, 2017, 11:54 p.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64353/ > ----------------------------------------------------------- > > (Updated Dec. 18, 2017, 11:54 p.m.) > > > Review request for mesos, Chun-Hung Hsiao and Jie Yu. > > > Bugs: MESOS-8251 > https://issues.apache.org/jira/browse/MESOS-8251 > > > Repository: mesos > > > Description > ------- > > This example module shows how a VolumeProfile module might be > implemented (and is a viable module in its own right). The module > can be configured to fetch a map of profiles from a URI (`file://` or > `http(s)://`) and possibly cache this item for some time. > > > Diffs > ----- > > src/Makefile.am f5a4edd245e8d6535502e951ecaa526c2bae25f9 > src/csi/uri_volume_profile.proto PRE-CREATION > src/resource_provider/uri_volume_profile.hpp PRE-CREATION > src/resource_provider/uri_volume_profile.cpp PRE-CREATION > > > Diff: https://reviews.apache.org/r/64353/diff/7/ > > > Testing > ------- > > See end of chain. > > > Thanks, > > Joseph Wu > >
