> On Dec. 19, 2017, 12:12 a.m., Jie Yu wrote: > > src/resource_provider/storage/provider.cpp > > Lines 2587-2588 (patched) > > <https://reviews.apache.org/r/64658/diff/6/?file=1919423#file1919423line2603> > > > > Maybe we need a helper here? > > > > `Result<string> getDiskProfile(const Resource& resource)`
Alternatively, I'll have an `Option<Resource> source` and do `source->disk().source().has_profile()`. P.S. I don't feel that we need to do `has_disk()` and `disk().has_source()`, because the protobuf library will return an empty `Source` for `.disk().source()` if these messages don't exist. - Chun-Hung ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64658/#review194084 ----------------------------------------------------------- On Dec. 18, 2017, 2:25 a.m., Chun-Hung Hsiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64658/ > ----------------------------------------------------------- > > (Updated Dec. 18, 2017, 2:25 a.m.) > > > Review request for mesos, Jie Yu and Joseph Wu. > > > Repository: mesos > > > Description > ------- > > This changes the Storage Local Resource Provider's source of profile > information from only using the default to using a VolumeProfileAdaptor > module. > > This patch is based on https://reviews.apache.org/r/64616. > > > Diffs > ----- > > src/resource_provider/storage/provider.cpp > 158b6b408002209aa9a79a6772da30c984aad61a > > > Diff: https://reviews.apache.org/r/64658/diff/6/ > > > Testing > ------- > > See later in chain. This patch will fail SLRP tests. They are fixed in a > followup patch. > > > Thanks, > > Chun-Hung Hsiao > >
