----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64701/ -----------------------------------------------------------
Review request for mesos, Akash Gupta, Joseph Wu, and Michael Park. Repository: mesos Description ------- After upgrading Visual Studio to 15.5.2, warning C4530 started being emitted for practically every file. Since we use the STL (which uses exceptions), apparently we need to compile with `/EHsc`. This sets the exception-handling model to catch C++ exceptions, and to assume that functions declared as `extern "C"` never throw a C++ exception. Diffs ----- cmake/CompilationConfigure.cmake dc9dc161dce1c714748bcec2fc15c4fbfbccaec2 Diff: https://reviews.apache.org/r/64701/diff/1/ Testing ------- Built on Windows, warning is gone (and gone in 3rdparty builds too). Thanks, Andrew Schwartzmeyer
