----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64659/#review194159 -----------------------------------------------------------
Fix it, then Ship it! src/Makefile.am Line 2652 (original) <https://reviews.apache.org/r/64659/#comment272889> Let's follow up with a patch in this chain to add those tests back. Discussed offline with Chun, the proposal is: 1) Rename UriVolumeProfileMapping to VolumeProfileMapping, and move the proto to `include/mesos/resource_provider/volume_profile.proto` 2) Introduce a util function to parse and validate volume profile mapping in src/resource_provider/storage 3) Move volume profile releated code to src/resource_provider/storage because it's storage related - Jie Yu On Dec. 19, 2017, 2:32 p.m., Chun-Hung Hsiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64659/ > ----------------------------------------------------------- > > (Updated Dec. 19, 2017, 2:32 p.m.) > > > Review request for mesos, Jie Yu and Joseph Wu. > > > Repository: mesos > > > Description > ------- > > This patch loads `liburi_volume_profile` dynamically and uses it in the > unit tests of storage local resource providers. > > NOTE: `volume_profile_tests.cpp` is removed from compilation to avoid\ > loading `uri_volume_profile.proto` twice. > > > Diffs > ----- > > src/Makefile.am 4623cfcdd0920367043db47f7ab261496996f33a > src/tests/agent_resource_provider_config_api_tests.cpp > 3c68b732a1d41561f98206a55ac09d91229f330a > src/tests/storage_local_resource_provider_tests.cpp > 1f11825001768864b61fdebdb24168790d7ec4fe > > > Diff: https://reviews.apache.org/r/64659/diff/3/ > > > Testing > ------- > > sudo make check > > > Thanks, > > Chun-Hung Hsiao > >
