----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64726/#review194261 -----------------------------------------------------------
include/mesos/mesos.proto Line 2279 (original), 2277 (patched) <https://reviews.apache.org/r/64726/#comment272985> Should we call this `uuid` because the context is Operation? include/mesos/scheduler/scheduler.proto Line 252 (original), 252 (patched) <https://reviews.apache.org/r/64726/#comment272987> ACKNOWLEDGE_OPERATION_STATUS? include/mesos/scheduler/scheduler.proto Line 406 (original), 406 (patched) <https://reviews.apache.org/r/64726/#comment272986> Should that be `ACKNOWLEDGE_OPERATION_STATUS` to be consistently with RP api? include/mesos/scheduler/scheduler.proto Lines 491-492 (original), 492 (patched) <https://reviews.apache.org/r/64726/#comment272988> Ditto src/messages/messages.proto Line 411 (original), 411 (patched) <https://reviews.apache.org/r/64726/#comment272989> Either we use OperationUpdateXXX or OperationStatusXXX, but let's be consistent. - Jie Yu On Dec. 20, 2017, 2:53 a.m., Gaston Kleiman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64726/ > ----------------------------------------------------------- > > (Updated Dec. 20, 2017, 2:53 a.m.) > > > Review request for mesos, Chun-Hung Hsiao, Greg Mann, Jie Yu, and Vinod Kone. > > > Repository: mesos > > > Description > ------- > > Renamed operation protos for consistency. > > > Diffs > ----- > > include/mesos/mesos.proto bf2ec8f4630fb32a36a1a0d49de23e0ddc0c6c84 > include/mesos/resource_provider/resource_provider.proto > 4534049bce3948f20a00cd704f09173077c8cdf8 > include/mesos/scheduler/scheduler.proto > a7907e2c0a8e0f23690179b9e334377c4acc9068 > include/mesos/v1/mesos.proto 9e240c0756ee9747f1ef226db963dfc6ab5c699a > include/mesos/v1/resource_provider/resource_provider.proto > beb9f1734b8d916150ecc6ed1c5b86f0672cd941 > include/mesos/v1/scheduler/scheduler.proto > e115bca04646133cfa3bbd6e7ba190b69f807f2b > src/messages/messages.proto baefbe97b57d28d70d8952604d12cdc543eaced4 > src/resource_provider/state.proto e3362a958851cefc175ee9ba0563da2b8bf8bb08 > > > Diff: https://reviews.apache.org/r/64726/diff/3/ > > > Testing > ------- > > > Thanks, > > Gaston Kleiman > >
