----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64758/#review194288 -----------------------------------------------------------
Looks good! Rather than "exclusively" how about all-or-nothing or is not chopped during allocation? Exclusively seems to suggest on its own without anything else. src/tests/hierarchical_allocator_tests.cpp Lines 3390 (patched) <https://reviews.apache.org/r/64758/#comment273033> Maybe indivisible or unchoppable instead of exclusive? src/tests/hierarchical_allocator_tests.cpp Lines 3393 (patched) <https://reviews.apache.org/r/64758/#comment273034> Ditto here. src/tests/hierarchical_allocator_tests.cpp Lines 3403 (patched) <https://reviews.apache.org/r/64758/#comment273035> seems like agentResources should include the mount disk? src/tests/hierarchical_allocator_tests.cpp Lines 3476-3478 (patched) <https://reviews.apache.org/r/64758/#comment273036> This subtraction a little puzzling to follow, is it possible to just use agent3.resources() - some disk due to chopping? - Benjamin Mahler On Dec. 20, 2017, 10:07 p.m., Meng Zhu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64758/ > ----------------------------------------------------------- > > (Updated Dec. 20, 2017, 10:07 p.m.) > > > Review request for mesos, Benjamin Mahler and Michael Park. > > > Repository: mesos > > > Description > ------- > > While quota allocation should be fine-grained, some resources are > exclusive. They cannot be chopped into finer granularity and have > to be offered entirely. This test verifies one of the cases: disk > resource of type MOUNT. > > > Diffs > ----- > > src/tests/hierarchical_allocator_tests.cpp > 173e4fbac184ad8d40c8adba19ad64225f11f1f2 > > > Diff: https://reviews.apache.org/r/64758/diff/1/ > > > Testing > ------- > > make check > > > Thanks, > > Meng Zhu > >
