----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64755/#review194351 -----------------------------------------------------------
Fix it, then Ship it! src/resource_provider/storage/provider.cpp Lines 255-256 (original), 255-258 (patched) <https://reviews.apache.org/r/64755/#comment273115> Hum, I'd avoid using `parse`, instead, create it like you did before. src/slave/containerizer/containerizer.cpp Line 161 (original), 161 (patched) <https://reviews.apache.org/r/64755/#comment273116> Can we preserve the existing behavior? src/slave/containerizer/containerizer.cpp Line 189 (original), 189 (patched) <https://reviews.apache.org/r/64755/#comment273117> Ditto. Can we preserve the existing behavior? src/slave/slave.cpp Lines 5614 (patched) <https://reviews.apache.org/r/64755/#comment273118> I'd preserve the existing behavior in this patch - Jie Yu On Dec. 21, 2017, 3:41 a.m., Chun-Hung Hsiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64755/ > ----------------------------------------------------------- > > (Updated Dec. 21, 2017, 3:41 a.m.) > > > Review request for mesos, Benjamin Bannier, Benjamin Mahler, Jie Yu, and > Vinod Kone. > > > Repository: mesos > > > Description > ------- > > Removed the usage of `Bytes::kilobytes()` and `Bytes::megabytes()`. > > > Diffs > ----- > > src/examples/balloon_executor.cpp 7343ee72c1fc8d6e58527809ffb74fc5dd09ee0e > src/examples/balloon_framework.cpp a36e04b033ba66ba911abde2ad3d6f58decae18a > src/examples/disk_full_framework.cpp > d9d2d3513529f3a19f392b314001930746d5c91d > src/master/validation.cpp 7f5a67d98dbbd5a5d64bc73d530f3d37b3cdfec6 > src/resource_provider/storage/provider.cpp > 833d929e93afd0bb99a9574df24168e82269bc81 > src/slave/containerizer/containerizer.cpp > 935dfc9ea787ae714a86c7bc54811703c23267c8 > src/slave/containerizer/mesos/isolators/cgroups/subsystems/memory.cpp > 113e908743b718e7ad645e8e08b481ed97a4021f > src/slave/slave.cpp 6271cfe56733ec121d0d7c691e3dd0792435bf2d > src/tests/container_logger_tests.cpp > b65cf6a9096dfaa418fd7eb400771cc6df642ea2 > src/tests/containerizer/docker_containerizer_tests.cpp > 630bb2e352dd55ecb401730c84f823e0a1f2d310 > src/tests/hierarchical_allocator_tests.cpp > 173e4fbac184ad8d40c8adba19ad64225f11f1f2 > src/tests/mesos.hpp 41f47cf1b10fddd51e260e2127e2695ffe1aeba5 > src/tests/persistent_volume_tests.cpp > 854676918dba497e1a8c21d877631c6e5c75ee2e > > > Diff: https://reviews.apache.org/r/64755/diff/2/ > > > Testing > ------- > > sudo make check > > > Thanks, > > Chun-Hung Hsiao > >
