----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64792/#review194387 -----------------------------------------------------------
Ship it! Ship It! - Benjamin Mahler On Dec. 22, 2017, 12:47 a.m., Meng Zhu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64792/ > ----------------------------------------------------------- > > (Updated Dec. 22, 2017, 12:47 a.m.) > > > Review request for mesos and Benjamin Mahler. > > > Repository: mesos > > > Description > ------- > > Only resources allocated towards a role's quota should be > subtracted from `requiredHeadroom`. In addition to this, > unreserved resources in the quota allocation stage may also > contain resources that a role does not have quota for, they > should not be subtracted from `requiredHeadroom`. > > > Diffs > ----- > > src/master/allocator/mesos/hierarchical.cpp > 7f7dae1950bebd22191189c2db0f6678d2e8fa3c > > > Diff: https://reviews.apache.org/r/64792/diff/2/ > > > Testing > ------- > > make check > > > Thanks, > > Meng Zhu > >
