> On Dec. 21, 2017, 6:52 p.m., Benjamin Mahler wrote: > > Nice test! Just some minor suggestions below and what looks like an > > inaccurate comment?
Thanks! Comments fixed. - Meng ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64794/#review194395 ----------------------------------------------------------- On Dec. 21, 2017, 4:48 p.m., Meng Zhu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64794/ > ----------------------------------------------------------- > > (Updated Dec. 21, 2017, 4:48 p.m.) > > > Review request for mesos and Benjamin Mahler. > > > Bugs: MESOS-8352 > https://issues.apache.org/jira/browse/MESOS-8352 > > > Repository: mesos > > > Description > ------- > > This test verifies the behavior of allocating resource to quota roles > that has no quota set for that particular resource (e.g. allocating > memory to a role with only quota set for CPU). If a role has no quota > set for a resource, it will get that resource only when two conditions > are both met: > > - It got some other resources on the same agent to meet its quota; > > - After allocating the resource, there is still enough resource > available to meet all other role's quota guarantee for that resource. > > > Diffs > ----- > > src/tests/hierarchical_allocator_tests.cpp > ad9d556f040b2b51b6c43757f8bad05d61a057e7 > > > Diff: https://reviews.apache.org/r/64794/diff/2/ > > > Testing > ------- > > make check > > > Thanks, > > Meng Zhu > >
