----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64811/#review194456 -----------------------------------------------------------
Ship it! Ship It! - Chun-Hung Hsiao On Dec. 22, 2017, 7:47 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64811/ > ----------------------------------------------------------- > > (Updated Dec. 22, 2017, 7:47 p.m.) > > > Review request for mesos, Chun-Hung Hsiao, Gilbert Song, and Julien Pepy. > > > Bugs: MESOS-7007 > https://issues.apache.org/jira/browse/MESOS-7007 > > > Repository: mesos > > > Description > ------- > > After this patch, the invariant becomes that for command tasks, we > always set the ContainerInfo of the generated ExecutorInfo to be the > same as that in TaskInfo (if exists). This simplifies the logic when we > actually generate ContainerInfo for containerizer during launching > phase. > > This also made the logic introduced in the following patch more readable > and maintainable: https://reviews.apache.org/r/63598 > > > Diffs > ----- > > src/slave/slave.cpp 47d5632115bbfd2b729dc2388c01733f907cf938 > > > Diff: https://reviews.apache.org/r/64811/diff/1/ > > > Testing > ------- > > sudo make check > > > Thanks, > > Jie Yu > >
