----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64868/#review194653 -----------------------------------------------------------
docs/csi.md Lines 21 (patched) <https://reviews.apache.org/r/64868/#comment273568> Another nit: s/third party/third-party/ docs/csi.md Lines 48 (patched) <https://reviews.apache.org/r/64868/#comment273569> s/from the that/from that/ docs/csi.md Lines 288-291 (patched) <https://reviews.apache.org/r/64868/#comment273572> s/framework/scheduler/ s/that is available to the frameworks/that is available to them/ s/Here are the tips to/A tip to/ docs/csi.md Lines 293 (patched) <https://reviews.apache.org/r/64868/#comment273573> Nit: s/ Reservation/ Reservation/ docs/csi.md Lines 298 (patched) <https://reviews.apache.org/r/64868/#comment273575> +1 docs/csi.md Lines 304 (patched) <https://reviews.apache.org/r/64868/#comment273574> s/CSI plugin/a CSI plugin/ docs/csi.md Lines 529 (patched) <https://reviews.apache.org/r/64868/#comment273576> s/SLRP/SLRPs/? docs/csi.md Lines 689 (patched) <https://reviews.apache.org/r/64868/#comment273584> s/to a directory/in a directory/ docs/csi.md Lines 690 (patched) <https://reviews.apache.org/r/64868/#comment273585> s/set agent flag/set the agent flag/ docs/csi.md Lines 698 (patched) <https://reviews.apache.org/r/64868/#comment273587> s/agent flag/the agent flag/ docs/csi.md Lines 781-783 (patched) <https://reviews.apache.org/r/64868/#comment273588> We should probalby say what's the difference between removing an SLRP and marking it as gone. I guess that a SLRP can't be re-added after having marked it as gone. - Gaston Kleiman On Dec. 28, 2017, 8:53 p.m., Jie Yu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64868/ > ----------------------------------------------------------- > > (Updated Dec. 28, 2017, 8:53 p.m.) > > > Review request for mesos, Benjamin Bannier, Chun-Hung Hsiao, Gaston Kleiman, > Greg Mann, Joseph Wu, and Jan Schlicht. > > > Repository: mesos > > > Description > ------- > > Added initial doc about CSI support in Mesos. > > > Diffs > ----- > > docs/csi.md PRE-CREATION > > > Diff: https://reviews.apache.org/r/64868/diff/2/ > > > Testing > ------- > > The rendering can be checked here: > https://github.com/jieyu/mesos/blob/csi_doc/docs/csi.md > > > Thanks, > > Jie Yu > >
