----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64739/#review194659 -----------------------------------------------------------
Ship it! Is there a ticket for being more robust in the face of inability to recover a downgraded agent? Can you file one if not? Also, do we want to target a ticket for 2.1 that stops downgrading? I assume the strategy to end the 1.x deprecation cycle will be that 2.1+ only supports being upgraded from 2.0.x. src/resource_provider/storage/provider.cpp Line 663 (original), 663-664 (patched) <https://reviews.apache.org/r/64739/#comment273578> Do you want a TODO here to use a reflection based approach? src/resource_provider/storage/provider.cpp Lines 854-862 (patched) <https://reviews.apache.org/r/64739/#comment273579> Ditto here src/slave/containerizer/mesos/paths.cpp Lines 288-289 (patched) <https://reviews.apache.org/r/64739/#comment273580> Ditto here src/slave/containerizer/mesos/paths.cpp Lines 341-350 (patched) <https://reviews.apache.org/r/64739/#comment273581> Ditto here. - Benjamin Mahler On Dec. 20, 2017, 12:51 a.m., Michael Park wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64739/ > ----------------------------------------------------------- > > (Updated Dec. 20, 2017, 12:51 a.m.) > > > Review request for mesos and Benjamin Mahler. > > > Repository: mesos > > > Description > ------- > > See summary. > > > Diffs > ----- > > src/resource_provider/storage/provider.cpp > 79d7f602bbc57bce308157dfbb6c2afaef806f23 > src/slave/containerizer/mesos/paths.cpp > 8a188a918873eef468a984b80f5ea7ebaa8fb923 > > > Diff: https://reviews.apache.org/r/64739/diff/1/ > > > Testing > ------- > > > Thanks, > > Michael Park > >
