----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64899/#review194678 -----------------------------------------------------------
Ship it! Ship It! - Jie Yu On Jan. 2, 2018, 10:48 p.m., Chun-Hung Hsiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64899/ > ----------------------------------------------------------- > > (Updated Jan. 2, 2018, 10:48 p.m.) > > > Review request for mesos, Jie Yu and James Peach. > > > Bugs: MESOS-8370 > https://issues.apache.org/jira/browse/MESOS-8370 > > > Repository: mesos > > > Description > ------- > > Adding generated protobuf headers into `nodist_*_SOURCES` for modules > doesn't enfource build dependencies in the generated makefile so the > lines are removed. > > NOTE: Currently `liburi_volume_profile.la` cannot be built standalone. > The issue is tracked in MESOS-8370. > > > Diffs > ----- > > src/Makefile.am b83cddaaf874b669c0b8f9df8805fc88e8c3e90d > > > Diff: https://reviews.apache.org/r/64899/diff/1/ > > > Testing > ------- > > make distcheck > > > Thanks, > > Chun-Hung Hsiao > >
