----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64920/#review194717 -----------------------------------------------------------
Fix it, then Ship it! Looks good, although I was puzzled about the Try? Can you document when it returns Error? Or s/Try/void/ if it can't fail? src/common/resources_utils.hpp Lines 161-162 (patched) <https://reviews.apache.org/r/64920/#comment273647> When does this return Error? If never, should you s/Try/void/? - Benjamin Mahler On Jan. 3, 2018, 7:02 p.m., Michael Park wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64920/ > ----------------------------------------------------------- > > (Updated Jan. 3, 2018, 7:02 p.m.) > > > Review request for mesos and Benjamin Mahler. > > > Bugs: MESOS-8375 > https://issues.apache.org/jira/browse/MESOS-8375 > > > Repository: mesos > > > Description > ------- > > Introduced `upgradeResources` to complement `downgradeResources`. > > > Diffs > ----- > > src/common/resources_utils.hpp 115efc2868be3deab7af3f9a30dd26ca3c49a8a6 > src/common/resources_utils.cpp bd9e025c29fc100121dd187603b2b116207762ba > > > Diff: https://reviews.apache.org/r/64920/diff/1/ > > > Testing > ------- > > > Thanks, > > Michael Park > >
