----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/63860/#review194784 -----------------------------------------------------------
I like the direction in the latest diff (platform specific defaults). One question is: what's the difference between nat and bridge? are they the same? If yes, can we not have NAT in the API? In other words, BRIDGE on Windows will map to "nat". - Jie Yu On Dec. 7, 2017, 9:34 p.m., Akash Gupta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/63860/ > ----------------------------------------------------------- > > (Updated Dec. 7, 2017, 9:34 p.m.) > > > Review request for mesos, Andrew Schwartzmeyer, Jie Yu, John Kordich, Joseph > Wu, and Michael Park. > > > Bugs: MESOS-7342 > https://issues.apache.org/jira/browse/MESOS-7342 > > > Repository: mesos > > > Description > ------- > > The current Network enum in DockerInfo is specific to Linux containers. > Instead of supporting {host, bridge, none, user} networks, Windows > docker supports {nat, none, user} networks. Now, the Network enum > supports {host, bridge, nat, none, user}. If the network isn't > specified, then the default is host on Linux and nat on Windows. > > > Diffs > ----- > > include/mesos/mesos.proto 839ddb1cb41471d36423a2fc149acf90b973d413 > src/docker/docker.cpp 722a54ad113fc4e2bb22a8f08e307ab38d5fbfed > > > Diff: https://reviews.apache.org/r/63860/diff/4/ > > > Testing > ------- > > See https://reviews.apache.org/r/63862/ for test results. > > > Thanks, > > Akash Gupta > >
