> On Jan. 2, 2018, 7:23 p.m., Gaston Kleiman wrote: > > src/tests/fetcher_cache_tests.cpp > > Lines 391-393 (original), 393-399 (patched) > > <https://reviews.apache.org/r/64879/diff/1/?file=1929288#file1929288line393> > > > > Can't we just do `return os::access(path, X_OK);` here?
Good point! > On Jan. 2, 2018, 7:23 p.m., Gaston Kleiman wrote: > > src/tests/fetcher_cache_tests.cpp > > Line 503 (original), 523 (patched) > > <https://reviews.apache.org/r/64879/diff/1/?file=1929288#file1929288line526> > > > > you're overwriting `_task.runDirectory` here, is that intentional? Yep. I added a comment. - James ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64879/#review194603 ----------------------------------------------------------- On Dec. 30, 2017, 8:06 p.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64879/ > ----------------------------------------------------------- > > (Updated Dec. 30, 2017, 8:06 p.m.) > > > Review request for mesos, Alexander Rukletsov, Anand Mazumdar, and Jie Yu. > > > Bugs: MESOS-8366 > https://issues.apache.org/jira/browse/MESOS-8366 > > > Repository: mesos > > > Description > ------- > > Updated the task launch helper to obtain the ContainerID of the > launched task, which can be used to correctly construct the sandbox > path for both the command and default executors. > > Updated the test expectations in cases where the default executor > container will invoke the fetcher more times than the test is > expecting. > > Updated various test helper functions to propagate more detailed > error results that make test failure easier to debug. > > > Diffs > ----- > > src/tests/fetcher_cache_tests.cpp 7db7b7dcef27b1686ccae5a7408ff2811a3b9255 > > > Diff: https://reviews.apache.org/r/64879/diff/2/ > > > Testing > ------- > > make check (Fedora 27) > > > Thanks, > > James Peach > >
