----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64805/#review194850 -----------------------------------------------------------
Ship it! Ship It! - Jan Schlicht On Dec. 22, 2017, 2:36 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64805/ > ----------------------------------------------------------- > > (Updated Dec. 22, 2017, 2:36 p.m.) > > > Review request for mesos, Jie Yu and Jan Schlicht. > > > Repository: mesos > > > Description > ------- > > The class 'ConstantEndpointDetector' was holding a reference to one of > its constructor parameters which introduces unnecessary brittleness. > > In this patch we adjust the class to just hold a copy of the > originally passed value instead. > > > Diffs > ----- > > src/resource_provider/detector.hpp 68ea8cf2de4f2decc3eede16cf59fa8a851502f4 > > > Diff: https://reviews.apache.org/r/64805/diff/1/ > > > Testing > ------- > > `make check` > > > Thanks, > > Benjamin Bannier > >
