----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64730/#review194910 -----------------------------------------------------------
Ship it! Ship It! - Joseph Wu On Jan. 5, 2018, 1:53 p.m., Andrew Schwartzmeyer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64730/ > ----------------------------------------------------------- > > (Updated Jan. 5, 2018, 1:53 p.m.) > > > Review request for mesos, Greg Mann, Jie Yu, Joseph Wu, and Michael Park. > > > Repository: mesos > > > Description > ------- > > Also applies to `DRFSorter::count()`. The implementations return > `hashmap::count()` which is a `size_t`. Converting `size_t` to `int` > implicitly generates a "possible loss of data" warning. > > > Diffs > ----- > > src/master/allocator/sorter/drf/sorter.hpp > 1a7681c69b3d28efbf3d37dfaece55743e48c101 > src/master/allocator/sorter/drf/sorter.cpp > ecc5586737b6b447c5a1cf1a37037832bcbacd69 > src/master/allocator/sorter/sorter.hpp > 2c6e1621fc8b3a01750f6fa3b15f5dcd57216cc6 > > > Diff: https://reviews.apache.org/r/64730/diff/1/ > > > Testing > ------- > > > Thanks, > > Andrew Schwartzmeyer > >
