----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65013/#review194956 -----------------------------------------------------------
Ship it! This looks fine to me, though what it means for the Windows build isn't clear. Let's see what the Windows buildbot thinks before we commit. - James Peach On Jan. 8, 2018, 12:57 a.m., Benjamin Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65013/ > ----------------------------------------------------------- > > (Updated Jan. 8, 2018, 12:57 a.m.) > > > Review request for mesos, James Peach and Michael Park. > > > Repository: mesos > > > Description > ------- > > We require pthread and therefore the GTEST_IS_THREADSAFE macro > always returns true within the libprocess tests. Similar to what > is done in Mesos, we and exit if it's false. > > > Diffs > ----- > > 3rdparty/libprocess/src/tests/future_tests.cpp > 3dadd7298d2da1b3e39606f5b7843332e46c1835 > 3rdparty/libprocess/src/tests/io_tests.cpp > cc62d2f23f866314fb3433bfcd9528ef68ef7943 > 3rdparty/libprocess/src/tests/limiter_tests.cpp > 70a224cd7a28da300b819488bcb7ff4aa0e8f379 > 3rdparty/libprocess/src/tests/main.cpp > 1cbd37c54e67449148529c053415528832468dfb > 3rdparty/libprocess/src/tests/process_tests.cpp > 58741b2e8c1b3737e5569fc1346a9f5aa55fa3f3 > 3rdparty/libprocess/src/tests/reap_tests.cpp > 7e7aadc5b47fd8db059efd03d78b5c739794255d > > > Diff: https://reviews.apache.org/r/65013/diff/1/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Mahler > >
