----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65016/#review194981 -----------------------------------------------------------
Ship it! Thanks a lot for the cleanup! - Gaston Kleiman On Jan. 8, 2018, 2:05 a.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65016/ > ----------------------------------------------------------- > > (Updated Jan. 8, 2018, 2:05 a.m.) > > > Review request for mesos and Gaston Kleiman. > > > Repository: mesos > > > Description > ------- > > This replaces ad hoc validation checking e.g., whether required > example framework flags are present or contain permissable values with > delegation to in-built or injected validation functions in the > 'FlagsBase'. Some validation of flag dependencies remains. > > > Diffs > ----- > > src/examples/dynamic_reservation_framework.cpp > 538fbe8847a1b1dcbfe48ad0e3678797801a12f5 > src/examples/load_generator_framework.cpp > 42867992eba8699cab5b70c62a24b87446139406 > src/examples/no_executor_framework.cpp > 972ef777cec07d1030af208daef69ebe606d071e > src/examples/persistent_volume_framework.cpp > 71db39d7743d31ea34c2aed579d7a1ef2ed95687 > src/examples/test_framework.cpp acf1faf1523c8c03483dfafbc8f8e245322527e4 > src/examples/test_http_framework.cpp > 482f65efc15a7bac52c33a57b2b876191249410a > > > Diff: https://reviews.apache.org/r/65016/diff/1/ > > > Testing > ------- > > `make check` > > > Thanks, > > Benjamin Bannier > >
