----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64570/#review194991 -----------------------------------------------------------
Ship it! Ship It! - Gaston Kleiman On Jan. 4, 2018, 4:32 p.m., Akash Gupta wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64570/ > ----------------------------------------------------------- > > (Updated Jan. 4, 2018, 4:32 p.m.) > > > Review request for mesos, Alexander Rukletsov, Andrew Schwartzmeyer, Gaston > Kleiman, Jie Yu, and Michael Park. > > > Repository: mesos > > > Description > ------- > > The docker executor was setting its `PATH` through > `os::host_default_path()`, so it could not find the docker executable. > Now, on Windows, the docker executor inherits the environment variables > from the agent. Further investigation needs to be done on why `PATH` > was this way and if the docker executor could simply inherit the > agent's environment. > > > Diffs > ----- > > src/slave/containerizer/docker.cpp 890cb2aba44fe76e891117833eac8ccca00b759b > > > Diff: https://reviews.apache.org/r/64570/diff/2/ > > > Testing > ------- > > See https://reviews.apache.org/r/64386/ > > > Thanks, > > Akash Gupta > >
