> On Jan. 9, 2018, 1:29 a.m., Vinod Kone wrote: > > src/examples/example_framework_flags.hpp > > Lines 32 (patched) > > <https://reviews.apache.org/r/64847/diff/1/?file=1928736#file1928736line32> > > > > It's not clear to me why you broke down the flags like this? Also, not > > clear why v0 and v1 have different flags. Can you provide more context? > > Till Toenshoff wrote: > The breakdown happened on the basis of existing example framework > implementations and the features they offered. Formerly V0 example frameworks > used an explicit flag to signal authentication while the V1 examples simply > used the existence of a secret for enabling authentication. > Guess we can go for such flag everywhere to not close out ticket based > authentication (which might not even need a secret).
Simplified the grouping now. - Till ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64847/#review195007 ----------------------------------------------------------- On Jan. 9, 2018, 3:20 a.m., Till Toenshoff wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64847/ > ----------------------------------------------------------- > > (Updated Jan. 9, 2018, 3:20 a.m.) > > > Review request for mesos, Alexander Rukletsov, Armand Grillet, Greg Mann, > Kapil Arya, and Vinod Kone. > > > Bugs: MESOS-8357 > https://issues.apache.org/jira/browse/MESOS-8357 > > > Repository: mesos > > > Description > ------- > > Adds a set if flags exclusively used by our example frameworks. This > enhancement aids in unifying the user experience when tinkering with > our examples. > > > Diffs > ----- > > src/examples/flags.hpp PRE-CREATION > > > Diff: https://reviews.apache.org/r/64847/diff/2/ > > > Testing > ------- > > make check > > > Thanks, > > Till Toenshoff > >
