> On Jan. 9, 2018, 10:49 p.m., Gaston Kleiman wrote: > > src/examples/test_csi_user_framework.cpp > > Lines 422-432 (patched) > > <https://reviews.apache.org/r/65042/diff/2/?file=1937778#file1937778line450> > > > > It is not very clear to me why we need this block. > > > > Do we set `MESOS_AUTHENTICATE_HTTP_FRAMEWORKS` and > > `MESOS_HTTP_FRAMEWORK_AUTHENTICATORS` so that the scheduler driver knows > > how to authenticate with the local master? > > > > Why do we set `MESOS_ACLS`? The scheduler driver doesn't seem to use it.
The environment variables are for a started `local` mesos setup which is started by the scheduler's base class `MesosProcess`. - Benjamin ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65042/#review195078 ----------------------------------------------------------- On Jan. 10, 2018, 10:16 a.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65042/ > ----------------------------------------------------------- > > (Updated Jan. 10, 2018, 10:16 a.m.) > > > Review request for mesos, Gaston Kleiman and Till Toenshoff. > > > Repository: mesos > > > Description > ------- > > This patch adjusts the CSI example framework for recent cleanups to > example frameworks. It now uses generic flag classes which can e.g., > parse from both the environment and the command line. > > > Diffs > ----- > > src/examples/test_csi_user_framework.cpp PRE-CREATION > > > Diff: https://reviews.apache.org/r/65042/diff/3/ > > > Testing > ------- > > `make check` > > > Thanks, > > Benjamin Bannier > >
