----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64930/#review195151 -----------------------------------------------------------
Ship it! Ship It! - Benno Evers On Jan. 9, 2018, 8:06 a.m., Benjamin Mahler wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64930/ > ----------------------------------------------------------- > > (Updated Jan. 9, 2018, 8:06 a.m.) > > > Review request for mesos, Benno Evers and Vinod Kone. > > > Repository: mesos > > > Description > ------- > > The logic for marking an agent unreachable in the master had two > very similar code paths that differed slightly across failover > and steady state cases. This patch uses a single code path. > > Unfortunately, some slight differences were necessary, and a > failover boolean was introduced to accomodate them. Specifically, > the failover and steady state cases expect the agent to reside > in the recovered and registered lists, respectively. > > > Diffs > ----- > > src/master/master.hpp 130f6e28cc62a8912aac66ecfbf014fe1ee444e3 > src/master/master.cpp 1610f4331225235e85f5a83e5338870cef99a5c8 > src/tests/slave_tests.cpp 159192053087e971746943a1bc17a76143a2d9af > > > Diff: https://reviews.apache.org/r/64930/diff/2/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Mahler > >
