----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64992/#review195198 -----------------------------------------------------------
Fix it, then Ship it! src/tests/storage_local_resource_provider_tests.cpp Line 159 (original), 384 (patched) <https://reviews.apache.org/r/64992/#comment274354> Is there a reason to do this instead of pausing the clock and advancing it explicitly? src/tests/storage_local_resource_provider_tests.cpp Lines 455 (patched) <https://reviews.apache.org/r/64992/#comment274361> This can be removed. - Greg Mann On Jan. 10, 2018, 2:28 a.m., Chun-Hung Hsiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64992/ > ----------------------------------------------------------- > > (Updated Jan. 10, 2018, 2:28 a.m.) > > > Review request for mesos, Gaston Kleiman, Greg Mann, and Jie Yu. > > > Bugs: MESOS-8407 > https://issues.apache.org/jira/browse/MESOS-8407 > > > Repository: mesos > > > Description > ------- > > This patch adds the following tests: > > `NoResource`: RP updates its state with no resource, and can recover > from a checkpointed state that contains no resource. > > `ZeroSizedDisk`: CSI plugin reports a pre-existing volume with > zero capacity. > > `SmallDisk`: CSI plugin reports a storage pool and a pre-existing volume > with sizes < 1MB. > > `NewProfile`: A new profile is added after RP updates its state. > > > Diffs > ----- > > src/examples/test_csi_plugin.cpp f6b2c98c44366d5c752aa44bdbf8ae0374a7765c > src/tests/storage_local_resource_provider_tests.cpp > bbfe95e9818f25fdd5405db3ad2fe355e023f743 > > > Diff: https://reviews.apache.org/r/64992/diff/4/ > > > Testing > ------- > > sudo make check > > > Thanks, > > Chun-Hung Hsiao > >
