----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64978/#review195178 -----------------------------------------------------------
src/slave/slave.cpp Line 2795 (original), 2795 (patched) <https://reviews.apache.org/r/64978/#comment274325> s/the task's/default executor task's/ src/slave/slave.cpp Line 2796 (original), 2796 (patched) <https://reviews.apache.org/r/64978/#comment274320> s/we made/we made sure/ src/slave/slave.cpp Lines 2798 (patched) <https://reviews.apache.org/r/64978/#comment274321> s/add/adding/ src/slave/slave.cpp Lines 2800-2803 (patched) <https://reviews.apache.org/r/64978/#comment274323> Change this sentence to: ``` // This volume get translated into a bindmount in the nested container's // mount namespace, which is is not visible in Mesos UI because it // operates in the host namespace. See Mesos-8279 for details. ``` src/slave/slave.cpp Lines 2807 (patched) <https://reviews.apache.org/r/64978/#comment274324> s/attached/attach/ src/slave/slave.cpp Lines 2810 (patched) <https://reviews.apache.org/r/64978/#comment274327> s/specified, that is/ specified/ - Vinod Kone On Jan. 9, 2018, 2:11 p.m., Qian Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64978/ > ----------------------------------------------------------- > > (Updated Jan. 9, 2018, 2:11 p.m.) > > > Review request for mesos, Benjamin Mahler, Gilbert Song, Jie Yu, and Vinod > Kone. > > > Bugs: MESOS-8279 > https://issues.apache.org/jira/browse/MESOS-8279 > > > Repository: mesos > > > Description > ------- > > In MESOS-7225, we made a task can access any volumes specified in its > disk resources from its own sandbox by introducing a workaround to the > default executor, i.e., add a `SANDBOX_PATH` volume with type `PARENT` > to the corresponding nested container. It will be translated into a bind > mount in the nested container's mount namespace, thus not visible in the > host mount namespace, that means the task's volume directory can not be > visible in Mesos UI since it operates in the host mount namespace. > > In this patch, to make the task's volume directory visible in Mesos UI, > we attached the executor's volume directory to it, so when users browse > task's volume directory in Mesos UI, what they actually browse is the > executor's volume directory. Note when calling `Files::attach()`, the > third argument `authorized` is not specified, that is because it is > already specified when we do the attach for the executor's sandbox and > it is also applied to the executor's tasks. > > > Diffs > ----- > > src/slave/slave.cpp aeb0fdaeda78f26de2ec790735bfa88c5be72850 > > > Diff: https://reviews.apache.org/r/64978/diff/3/ > > > Testing > ------- > > sudo make check > > > Thanks, > > Qian Zhang > >
