> On Jan. 9, 2018, 8:12 a.m., Jie Yu wrote: > > src/slave/slave.cpp > > Lines 2795-2829 (patched) > > <https://reviews.apache.org/r/64978/diff/2/?file=1934306#file1934306line2799> > > > > I am flying by. I am wondering if we should add this logic to > > `Executor::addLaunchedTask` and `Executor::recoverTask`? > > Qian Zhang wrote: > It is already in `Executor::recoverTask`. For > `Executor::addLaunchedTask`, yeah, we can move it there, but > `Executor::addLaunchedTask` is called in `Slave::___run` for both task and > task group, I'd prefer to minimize the impact to task but only focus on task > group. So I think it's better to keep `Executor::addLaunchedTask` as simple > as it is.
Second thought, we can check if it is default executor before doing the attach, so it should be OK for both task and task group. I will move it there later. - Qian ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64978/#review195003 ----------------------------------------------------------- On Jan. 9, 2018, 10:11 p.m., Qian Zhang wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64978/ > ----------------------------------------------------------- > > (Updated Jan. 9, 2018, 10:11 p.m.) > > > Review request for mesos, Benjamin Mahler, Gilbert Song, Jie Yu, and Vinod > Kone. > > > Bugs: MESOS-8279 > https://issues.apache.org/jira/browse/MESOS-8279 > > > Repository: mesos > > > Description > ------- > > In MESOS-7225, we made a task can access any volumes specified in its > disk resources from its own sandbox by introducing a workaround to the > default executor, i.e., add a `SANDBOX_PATH` volume with type `PARENT` > to the corresponding nested container. It will be translated into a bind > mount in the nested container's mount namespace, thus not visible in the > host mount namespace, that means the task's volume directory can not be > visible in Mesos UI since it operates in the host mount namespace. > > In this patch, to make the task's volume directory visible in Mesos UI, > we attached the executor's volume directory to it, so when users browse > task's volume directory in Mesos UI, what they actually browse is the > executor's volume directory. Note when calling `Files::attach()`, the > third argument `authorized` is not specified, that is because it is > already specified when we do the attach for the executor's sandbox and > it is also applied to the executor's tasks. > > > Diffs > ----- > > src/slave/slave.cpp aeb0fdaeda78f26de2ec790735bfa88c5be72850 > > > Diff: https://reviews.apache.org/r/64978/diff/3/ > > > Testing > ------- > > sudo make check > > > Thanks, > > Qian Zhang > >
