----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65093/#review195239 -----------------------------------------------------------
Ship it! Thanks for splitting this up into a chain! - Greg Mann On Jan. 11, 2018, 1:53 p.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65093/ > ----------------------------------------------------------- > > (Updated Jan. 11, 2018, 1:53 p.m.) > > > Review request for mesos and Jan Schlicht. > > > Bugs: MESOS-8422 > https://issues.apache.org/jira/browse/MESOS-8422 > > > Repository: mesos > > > Description > ------- > > This replaces repetitive code by instead using a helper variable which > allows us to avoid branching. We can then also replace a `Try<bool>` > with a plain `bool` further simplifying the code. > > > Diffs > ----- > > src/master/master.cpp 7ed15e4ba2a31c5fe4b8571f645cdca69a3e82f4 > > > Diff: https://reviews.apache.org/r/65093/diff/1/ > > > Testing > ------- > > `make check` > > > Thanks, > > Benjamin Bannier > >
