----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64995/#review195242 -----------------------------------------------------------
Ship it! TL;DR: putting `path` into a temp variable so we can emit it in error messages, which indeed seems useful. LGTM. - Andrew Schwartzmeyer On Jan. 11, 2018, 10:44 a.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64995/ > ----------------------------------------------------------- > > (Updated Jan. 11, 2018, 10:44 a.m.) > > > Review request for mesos, Andrew Schwartzmeyer and Gilbert Song. > > > Bugs: MESOS-8404 > https://issues.apache.org/jira/browse/MESOS-8404 > > > Repository: mesos > > > Description > ------- > > When one of the image store backends fails to parse an image manifest, > it is most probable that the the on-disk state is incorrect. Emitting > the path in the error makes it easier for an operator to figure out > what went wrong. > > > Diffs > ----- > > src/appc/spec.cpp 8471ccb1452662e11aac01886dcc6af81558db27 > src/slave/containerizer/mesos/provisioner/appc/cache.cpp > 09190e2c21cf39ab023ee08e12cf10610343a103 > src/slave/containerizer/mesos/provisioner/docker/local_puller.cpp > c4879ecfe77bbeb9ec2922831d373695aeb4e180 > src/slave/containerizer/mesos/provisioner/docker/store.cpp > d64e6eb0f93a5d43ad756d4f0b0d1a665375dada > > > Diff: https://reviews.apache.org/r/64995/diff/1/ > > > Testing > ------- > > make check (Fedora 27) > > > Thanks, > > James Peach > >
