----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64729/#review195243 -----------------------------------------------------------
Fix it, then Ship it! This change seems safe to me, but it does make the `Duration` interface inconsistent. I'm fine with it for now, but can you add a big fat comment and a JIRA to come back and clean it up so that we don't have this special case? 3rdparty/stout/include/stout/duration.hpp Lines 176 (patched) <https://reviews.apache.org/r/64729/#comment274418> Too many blank lines :) - James Peach On Jan. 5, 2018, 9:53 p.m., Andrew Schwartzmeyer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64729/ > ----------------------------------------------------------- > > (Updated Jan. 5, 2018, 9:53 p.m.) > > > Review request for mesos, Greg Mann, Jie Yu, Joseph Wu, and Michael Park. > > > Repository: mesos > > > Description > ------- > > Without this change, every use of `Duration * 2` throws a conversion > warning because we multiple `Duration` by `int` and `size_t` without > casting to `double` (the type accepted by the actual implementation of > `operator*`). > > > Diffs > ----- > > 3rdparty/stout/include/stout/duration.hpp > d10b6a4d4d1a0096334c30fdec725ecc55c9f0ea > > > Diff: https://reviews.apache.org/r/64729/diff/3/ > > > Testing > ------- > > > Thanks, > > Andrew Schwartzmeyer > >
