----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65096/#review195304 -----------------------------------------------------------
Fix it, then Ship it! src/master/master.cpp Lines 10306 (patched) <https://reviews.apache.org/r/65096/#comment274482> Let's not use an empty string but " of a operator API call" here, as it's done in `Master::updateOperationStatus`. - Jan Schlicht On Jan. 12, 2018, 11:53 a.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65096/ > ----------------------------------------------------------- > > (Updated Jan. 12, 2018, 11:53 a.m.) > > > Review request for mesos and Jan Schlicht. > > > Bugs: MESOS-8422 > https://issues.apache.org/jira/browse/MESOS-8422 > > > Repository: mesos > > > Description > ------- > > This patch fixes logging of master's `updateOperation` for operations > without framework ID. We also add a `CHECK` before the part updating > resources or the allocator for non-speculated operations; currently > non-speculated operations can only be initiated from a framework, but > not from e.g., the operation API, and additional work is needed to > support this. > > > Diffs > ----- > > src/master/master.cpp 8921964a3ed74538b8c831a2f827d07875c1a5ab > > > Diff: https://reviews.apache.org/r/65096/diff/2/ > > > Testing > ------- > > `make check` > > > Thanks, > > Benjamin Bannier > >
