> On Jan. 12, 2018, 2:38 a.m., Vinod Kone wrote: > > src/slave/compatibility.cpp > > Line 156 (original), 135 (patched) > > <https://reviews.apache.org/r/65074/diff/1/?file=1938277#file1938277line163> > > > > s/by Mesos//. Seems redundant?
Without the suffix, the comment could be interpreted as saying that only the `additive`-policy doesn't support text resources. - Benno ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65074/#review195286 ----------------------------------------------------------- On Jan. 12, 2018, 3:40 p.m., Benno Evers wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65074/ > ----------------------------------------------------------- > > (Updated Jan. 12, 2018, 3:40 p.m.) > > > Review request for mesos, James Peach and Vinod Kone. > > > Bugs: MESOS-8410 > https://issues.apache.org/jira/browse/MESOS-8410 > > > Repository: mesos > > > Description > ------- > > The case where multiple resources have the same name > was not handled correctly, and could result in false > negatives. > > > Diffs > ----- > > include/mesos/resources.hpp 69bf823f800ac8bfc2bc211895b0967f573009b5 > src/common/resources.cpp 1291208b9f2a7c373ff7ec941d3e4310fec92207 > src/slave/compatibility.hpp 78b421a01abe5d2178c93832577577a7ba282b38 > src/slave/compatibility.cpp 4ead4a5b655f6f3d7812aa52d656830d7cff4598 > src/tests/slave_compatibility_tests.cpp > ab5ed29f43c593dbd7d90c235aa304b581d932a2 > > > Diff: https://reviews.apache.org/r/65074/diff/2/ > > > Testing > ------- > > * Several new unit tests added in the review > * `make check` > > > Thanks, > > Benno Evers > >
