----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65056/#review195370 -----------------------------------------------------------
Can you update the `GetMaster` test in api_tests.cpp? include/mesos/v1/master/master.proto Lines 468-472 (patched) <https://reviews.apache.org/r/65056/#comment274546> I would get rid of these for now. I would like this to be inferred from GetAgents instead of having it at 2 different places. src/master/http.cpp Lines 2274-2281 (patched) <https://reviews.apache.org/r/65056/#comment274545> i would put group these as: ``` getMaster->mutable_master_info()->CopyFrom(master->info()); getMaster->set_start_time(master->startTime.secs()); if (master->electedTime.isSome()) { getMaster->set_elected_time(master->electedTime.get().secs()); } getMaster->set_activated_agents(master->_slaves_active()); getMaster->set_deactivated_agents(master->_slaves_inactive()); getMaster->set_unreachable_agents(master->_slaves_unreachable()); ``` if you kill the `slaves_*` per comment above, i'll leave it upto you whether you want the space or not. - Vinod Kone On Jan. 13, 2018, 12:11 a.m., Greg Mann wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65056/ > ----------------------------------------------------------- > > (Updated Jan. 13, 2018, 12:11 a.m.) > > > Review request for mesos, Anand Mazumdar, Gaston Kleiman, and Vinod Kone. > > > Bugs: MESOS-8078 > https://issues.apache.org/jira/browse/MESOS-8078 > > > Repository: mesos > > > Description > ------- > > Several fields were present in the old master '/state' endpoint, > which are now not accessible via the V1 operator API. This patch > adds these fields to the response for the GET_MASTER call. > > > Diffs > ----- > > include/mesos/master/master.proto f4506fe82ee7c1db77cfb7e94933d5a7f4b024df > include/mesos/v1/master/master.proto > 5cb64df12459b1529306cd33691c003172e4b3ec > src/master/http.cpp bc29fafb1f4b515aec3b77850f960c88a65c8362 > > > Diff: https://reviews.apache.org/r/65056/diff/3/ > > > Testing > ------- > > tested manually using curl > > > Thanks, > > Greg Mann > >
