-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/65147/
-----------------------------------------------------------
(Updated Jan. 12, 2018, 10:31 p.m.)
Review request for mesos, Akash Gupta, Jie Yu, and Joseph Wu.
Changes
-------
Skip the enable `INTERNET` filter tests because they fail on the bot, and
aren't necessary.
Bugs: MESOS-8443
https://issues.apache.org/jira/browse/MESOS-8443
Repository: mesos
Description
-------
`docker` isn't always installed in `os::host_default_path()` on Windows,
so the docker executor cannot find it. Now, before launching the
executor, the mesos agent finds `docker`'s parent directory and appends
that to `PATH`.
Diffs
-----
src/slave/containerizer/docker.cpp b42fe1f4b7151ee5cb1d7c680c7c0237882bd4bb
Diff: https://reviews.apache.org/r/65147/diff/1/
Testing
-------
Tested on Windows 10, all passed.
Integration tested (courtsey of Akash) that Docker containers can be launched
without manually fixing the path.
`make check` on CentOS 7, all passed.
NOTE: This is Windows-only, and replaces
[#64570](https://reviews.apache.org/r/64570/). Joseph and I worked out this
approach to prevent a regression for Mesos customers moving from `1.4` to
`1.5`; see MESOS-8443 for details.
Thanks,
Andrew Schwartzmeyer
