----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64907/#review195434 -----------------------------------------------------------
Ship it! Ship It! - Benjamin Mahler On Jan. 3, 2018, 7:20 a.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64907/ > ----------------------------------------------------------- > > (Updated Jan. 3, 2018, 7:20 a.m.) > > > Review request for mesos and Benjamin Mahler. > > > Repository: mesos > > > Description > ------- > > The current semantics for `loop()` mean that we'll leak resources > under two different circumstances: > > (1) If either the "iteration" or "body" functions return future's > that are abandoned. > > (2) If the loop is using a process that exits. > > This patch adds support to make sure that abandoned futures are > properly propagated in the event that either of these situations > occurs. > > > Diffs > ----- > > 3rdparty/libprocess/include/process/loop.hpp > 69d90f3e1b16189e0b1a6f1981e8509c18b38465 > 3rdparty/libprocess/src/tests/loop_tests.cpp > 8d1837a0baedc12591f92c8f0f8ea83d0aa44ab0 > > > Diff: https://reviews.apache.org/r/64907/diff/3/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Hindman > >
