----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64909/#review195435 -----------------------------------------------------------
Ship it! Ship It! - Benjamin Mahler On Jan. 3, 2018, 7:21 a.m., Benjamin Hindman wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64909/ > ----------------------------------------------------------- > > (Updated Jan. 3, 2018, 7:21 a.m.) > > > Review request for mesos and Benjamin Mahler. > > > Repository: mesos > > > Description > ------- > > We used `dispose` to capture the sockets that `HttpProxy` did not want > to persist but now that `HttpProxy` does not use `SocketManager` we no > longer need to use `dispose` because `temps` is sufficient for knowing > which sockets are temporary. > > > Diffs > ----- > > 3rdparty/libprocess/src/process.cpp > 2126c272a69bfa53b4b3cbbb1a55a3f81a5da8ad > 3rdparty/libprocess/src/socket_manager.hpp > dd4d111c4ae579420060e547d1111d12f8f0711c > > > Diff: https://reviews.apache.org/r/64909/diff/3/ > > > Testing > ------- > > make check > > > Thanks, > > Benjamin Hindman > >
