----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65105/#review195441 -----------------------------------------------------------
Fix it, then Ship it! src/slave/containerizer/mesos/isolators/network/ports.cpp Lines 528-530 (patched) <https://reviews.apache.org/r/65105/#comment274616> Can we keep these codes in 2 lines? And I do not think we need to call `stringify()` for `containerId` here. ``` LOG(INFO) << "Updated ports to " << intervalSetToRanges(info->ports.get()) << " for container " << containerId; ``` - Qian Zhang On Jan. 12, 2018, 9:14 a.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65105/ > ----------------------------------------------------------- > > (Updated Jan. 12, 2018, 9:14 a.m.) > > > Review request for mesos, Qian Zhang and Jiang Yan Xu. > > > Repository: mesos > > > Description > ------- > > Added a log message (similar to the one in the `cgroup/cpu` isolator > to track then the resouces for a container are updated. > > Hoisted a `CHECK` so that it happens before accessing the protobuf > field it is protecting. > > > Diffs > ----- > > src/slave/containerizer/mesos/isolators/network/ports.cpp > 7d5ff4f6d917352abd9ac0158a56eae7911aff0f > > > Diff: https://reviews.apache.org/r/65105/diff/1/ > > > Testing > ------- > > make check (Fedora 27) > > > Thanks, > > James Peach > >
