----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65114/#review195529 -----------------------------------------------------------
docs/c++-style-guide.md Lines 92 (patched) <https://reviews.apache.org/r/65114/#comment274733> Just FYI, we probably will remove get() at some point: https://issues.apache.org/jira/browse/MESOS-7124 - Benjamin Mahler On Jan. 16, 2018, 8:18 p.m., Andrew Schwartzmeyer wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65114/ > ----------------------------------------------------------- > > (Updated Jan. 16, 2018, 8:18 p.m.) > > > Review request for mesos, Benjamin Mahler, Greg Mann, Jie Yu, and Joseph Wu. > > > Repository: mesos > > > Description > ------- > > Added three missing style notes: > > * Use of `::` for global namespace > * Put `template <typename T>` on own line > * Prefer `->foo()` to `.get().foo()` > > > Diffs > ----- > > docs/c++-style-guide.md ef80c868fd3f366c998bc33c9f8a664dc35b0336 > > > Diff: https://reviews.apache.org/r/65114/diff/2/ > > > Testing > ------- > > > Thanks, > > Andrew Schwartzmeyer > >