----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65212/#review195742 -----------------------------------------------------------
Ship it! Ship It! - Michael Park On Jan. 18, 2018, 5:24 a.m., Benjamin Bannier wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65212/ > ----------------------------------------------------------- > > (Updated Jan. 18, 2018, 5:24 a.m.) > > > Review request for mesos and Michael Park. > > > Repository: mesos > > > Description > ------- > > This patch updates the `mesos-tidy` docker build setup to generate > `benchmarks.pb.h` needed by the libprocess benchmark files added as > part of `eb901173b8aa43b9fd1ab0f727ff5187982c4449`. > > We also reorder the targets to be build in the script so that all > proto targets are located close to each other and after manually > triggered 3rdparty dependencies (like e.g., protobuf). This should > reduce redudant build invocations. > > > Diffs > ----- > > support/mesos-tidy/entrypoint.sh dd83d66f48968bce652bc78ccf2d807949f1725b > > > Diff: https://reviews.apache.org/r/65212/diff/2/ > > > Testing > ------- > > Tested with a custom docker image and `support/mesos-tidy.sh` pointing to it. > > > Thanks, > > Benjamin Bannier > >
