----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65226/ -----------------------------------------------------------
Review request for mesos and Greg Mann. Bugs: MESOS-8413 https://issues.apache.org/jira/browse/MESOS-8413 Repository: mesos Description ------- The default behavior when serializing a flag, if its value comes from a file (by using the prefix `file://`) is to show the contents of the file instead of the path to the file. A common pattern for flags containing sensitive information is to store the values in a secure file, however the default behavior of serializing flags causes these values to be leaked when serializing a subclass of `FlagsBase`. This patch introduces the structure `SecurePathOrValue` so that the default behavior is overriden and the path of the flag will be shown instead of the flag value itself. Diffs ----- 3rdparty/stout/include/stout/flags/fetch.hpp 788d09e0a2083ead7d6ccb0c233cfdfd5d1ddb81 3rdparty/stout/include/stout/flags/flag.hpp 6580c294fc5d06854eadc19b1515172a4a700e89 3rdparty/stout/include/stout/flags/parse.hpp 6112d699be4cbdcb7a7872da8f29d41aab0939a3 Diff: https://reviews.apache.org/r/65226/diff/1/ Testing ------- ``` make check ``` Full testing in follow up patch. Thanks, Alexander Rojas