----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/64998/#review195834 -----------------------------------------------------------
Fix it, then Ship it! src/slave/container_daemon_process.hpp Lines 76-79 (patched) <https://reviews.apache.org/r/64998/#comment275162> Nit: one fewer newline here. I can fix this while committing. - Greg Mann On Jan. 18, 2018, 2:53 a.m., Chun-Hung Hsiao wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/64998/ > ----------------------------------------------------------- > > (Updated Jan. 18, 2018, 2:53 a.m.) > > > Review request for mesos, Gaston Kleiman, Greg Mann, and Jie Yu. > > > Bugs: MESOS-8408 > https://issues.apache.org/jira/browse/MESOS-8408 > > > Repository: mesos > > > Description > ------- > > The test does the same as the `PublishResources` test, but it kills the > CSI plugin contaier between each operation. > > > Diffs > ----- > > src/Makefile.am 191594b9d67f1aa1342efbaad5e7501004332d74 > src/slave/container_daemon.cpp d74fa5105c61a6cadfb2610790e559d387ca13a0 > src/slave/container_daemon_process.hpp PRE-CREATION > src/tests/storage_local_resource_provider_tests.cpp > bbfe95e9818f25fdd5405db3ad2fe355e023f743 > > > Diff: https://reviews.apache.org/r/64998/diff/6/ > > > Testing > ------- > > sudo make check > > > Thanks, > > Chun-Hung Hsiao > >
