----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65202/#review195696 -----------------------------------------------------------
src/logging/flags.hpp Lines 22 (patched) <https://reviews.apache.org/r/65202/#comment275365> Is this needed? src/tests/flags.cpp Lines 37 (patched) <https://reviews.apache.org/r/65202/#comment275367> Moving this out of the header is great. Let's do it in a separate, preceeding commit. src/tests/flags.cpp Lines 161 (patched) <https://reviews.apache.org/r/65202/#comment275368> Let's explicitly call out await in the flag name, e.g., something along the lines of `default_await_timeout`. src/tests/flags.cpp Lines 163 (patched) <https://reviews.apache.org/r/65202/#comment275369> We could explicitly call out await here as well, e.g., The default timeout for awaiting test events. src/tests/mesos.hpp Lines 94-99 (original), 94-100 (patched) <https://reviews.apache.org/r/65202/#comment274960> Since this is a header `using` decls lock fundamentally very, very wrong to me. Let's not add to this. src/tests/mesos.hpp Lines 100 (patched) <https://reviews.apache.org/r/65202/#comment275366> Let's not add more `using` decls to this header. - Benjamin Bannier On Jan. 18, 2018, 12:55 a.m., James Peach wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65202/ > ----------------------------------------------------------- > > (Updated Jan. 18, 2018, 12:55 a.m.) > > > Review request for mesos, Benjamin Bannier and Gaston Kleiman. > > > Bugs: MESOS-7016 > https://issues.apache.org/jira/browse/MESOS-7016 > > > Repository: mesos > > > Description > ------- > > Rather than hard-coding a 15sec test timeout, use the libprocess > `DEFAULT_TEST_TIMEOUT` variable so that this can be globally > tuned. Added a test flag `--default_timeout` that can be used > to set the `DEFAULT_TEST_TIMEOUT` on a test run. > > > Diffs > ----- > > src/logging/flags.hpp fe40a11c6a5e3ef44ecf008d1aa03d4e74e59859 > src/tests/agent_container_api_tests.cpp > 618569277545205017320aaf1f3a70e540d35e30 > src/tests/containerizer/cgroups_isolator_tests.cpp > 5412a7eccaa836a7f182772f1eb33b10298c96a1 > src/tests/containerizer/xfs_quota_tests.cpp > d761ea46fd4f12c6bed74090bf5ead7587f16811 > src/tests/disk_quota_tests.cpp 4e25e32bf784ea818e18497fe3ebc9f94c5861ff > src/tests/fetcher_cache_tests.cpp 7db7b7dcef27b1686ccae5a7408ff2811a3b9255 > src/tests/flags.hpp df4d4588f405ea884bb89021264e70218e054fae > src/tests/flags.cpp 4542f3443830474edd97e8b695af0c61685e947c > src/tests/gc_tests.cpp 0e34c017f2c629b527915218f517b88d8392aa4b > src/tests/main.cpp f945ac9e8858998174b4c2785f6a5612bae66a41 > src/tests/master_contender_detector_tests.cpp > 015d310b72a152829641d436f7cb558f72dfd77c > src/tests/mesos.hpp 16c75bb0ca570dfb7089743344cf38acdb517705 > src/tests/registrar_tests.cpp cbb58c1cd72dc13ed16b5465452d17526255c763 > src/tests/slave_recovery_tests.cpp 641fc6e82be19bdea55d35ec8f34a862de58489e > src/tests/slave_tests.cpp 59e3065ad9aadbd90cdfd32e830b433b88d6de86 > > > Diff: https://reviews.apache.org/r/65202/diff/1/ > > > Testing > ------- > > make check (Fedora 27). > > > Thanks, > > James Peach > >
