----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/65252/#review195950 -----------------------------------------------------------
Fix it, then Ship it! include/mesos/v1/mesos.proto Line 2459 (original), 2470 (patched) <https://reviews.apache.org/r/65252/#comment275388> Thanks for the cleanup! I did a diff, and in the v0 proto there's only one space after the period in this line. So I'd say we should: `s/meta-data. /meta-data. /` - Gaston Kleiman On Jan. 22, 2018, 1:59 p.m., Gilbert Song wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/65252/ > ----------------------------------------------------------- > > (Updated Jan. 22, 2018, 1:59 p.m.) > > > Review request for mesos, Benjamin Mahler, Chun-Hung Hsiao, Gaston Kleiman, > Greg Mann, Jie Yu, Michael Park, and Neil Conway. > > > Repository: mesos > > > Description > ------- > > Updated the v1/mesos.proto to keep consistancy with general mesos.proto. > > > Diffs > ----- > > include/mesos/v1/mesos.proto b8e016e60322879e53ffa3bef23481015b0a6d2d > > > Diff: https://reviews.apache.org/r/65252/diff/2/ > > > Testing > ------- > > > Thanks, > > Gilbert Song > >
